Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: port changes from C# NNS contract #2694

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

examples: port changes from C# NNS contract #2694

wants to merge 20 commits into from

Conversation

AnnaShaleva
Copy link
Member

This PR includes changes implemented into C# NNS version (https://github.com/neo-project/non-native-contracts/blob/master/src/NameService/NameService.cs):

  1. Domain registration price is dependant on domain name length. By default, short (<5 chars) domain names are available for registration only for committee.
  2. Renew overload is added that accepts expiration period as an argument. This change is backwords-compatible.
  3. SetAdmin and Renew events are added.

@AnnaShaleva
nns: adjust maxDomainNameFragmentLength
bd37220 
Port nspcc-dev/neofs-contract#238.
@AnnaShaleva
nns: allow hyphen in domain names
c11481b 
Port nspcc-dev/neofs-contract#183.
@AnnaShaleva
nns: replace root with TLD
5cb2a12 
Port
nspcc-dev/neofs-contract@4b86891.
@AnnaShaleva
nns: require admin signature for subdomain registration
017a6b9 
Port
nspcc-dev/neofs-contract@14fc086.
@AnnaShaleva
nns: check domain expiration for read functions
baf24d1 
Port nspcc-dev/neofs-contract@432c02a.
@AnnaShaleva
nns: allow to resolve FQDN
225152f 
Port nspcc-dev/neofs-contract@4041924.
@AnnaShaleva
nns: add admin to properties
d77b35c 
See https://github.com/neo-project/non-native-contracts/blob/14f43ba8cf169323b61c23a3a701ac77d9a4e3eb/src/NameService/NameService.cs#L69.
@AnnaShaleva
*: update basic test chain
4543de0 
Apply new NNS rules.
@AnnaShaleva
nns: add test for getAllRecords
c296f88
@AnnaShaleva
nns: allow multiple records of the same type
c9050ce 
Except for the CNAME records. Port
nspcc-dev/neofs-contract@6ea4573
and
nspcc-dev/neofs-contract@f4762c1.
@AnnaShaleva
nns: ensure records with the same type are not repeated
8790602 
Port nspcc-dev/neofs-contract#170.
@AnnaShaleva
nns: support SOA records
ea934b8 
Port nspcc-dev/neofs-contract@7f1ec13
and nspcc-dev/neofs-contract@f4762c1.
@AnnaShaleva
nns: allow arbitrary level domains
db9cea5 
Port
nspcc-dev/neofs-contract@d10da89.
@AnnaShaleva
nns: check for conflicting records on domain registration
d5b1c0e 
Port nspcc-dev/neofs-contract@f25296b.
@AnnaShaleva
nns: keep isAvailable in sync with register
d8e0a02 
If conflicting records '*.domain' are present on new domain
registration, then `isAvailable` should return false for this
domain. Ref.
nspcc-dev/neofs-contract@f25296b.
@AnnaShaleva
nns: use MillisecondsInSecond constant where appropriate
14c9858
@AnnaShaleva
nns: make domain registration price dependant on length
dea82ac 
Port neo-project/non-native-contracts@8ac2b80.
@AnnaShaleva
nns: accept expiration period in renew
9eed7c8 
Port neo-project/non-native-contracts#13.
@AnnaShaleva
nns: add SetAdmin event
748a7d3 
Port neo-project/non-native-contracts#11.
@AnnaShaleva
nns: add Renew event
abd332f 
Port neo-project/non-native-contracts#31.
@codecov
Copy link

codecov bot commented Sep 16, 2022 •
edited
Loading

Codecov Report

Merging #2694 (abd332f) into master (20224cb) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2694      +/-   ##
==========================================
+ Coverage   85.23%   85.50%   +0.27%     
==========================================
  Files         322      322              
  Lines       39398    39680     +282     
==========================================
+ Hits        33580    33928     +348     
+ Misses       4479     4423      -56     
+ Partials     1339     1329      -10
Impacted Files Coverage Δ
pkg/network/message.go 94.02% <0.00%> (-1.50%) ⬇️
pkg/services/notary/notary.go 82.08% <0.00%> (-0.55%) ⬇️
pkg/services/stateroot/network.go 76.71% <0.00%> (-0.32%) ⬇️
pkg/services/oracle/response.go 84.80% <0.00%> (-0.24%) ⬇️
pkg/network/server.go 73.08% <0.00%> (-0.17%) ⬇️
pkg/neorpc/errors.go 69.69% <0.00%> (ø)
pkg/rpcclient/nep11.go 0.00% <0.00%> (ø)
pkg/consensus/crypto.go 100.00% <0.00%> (ø)
pkg/rpcclient/policy.go 65.38% <0.00%> (ø)
pkg/util/slice/array.go 100.00% <0.00%> (ø)
... and 45 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov will be requested when the pull request is marked ready for review roman-khimov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AnnaShaleva